This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Call NetworkService::add_known_address before sending a request #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
rphmeier
approved these changes
Mar 26, 2021
eskimor
approved these changes
Mar 26, 2021
| Ok(v) => v, | ||
| Err(_) => continue, | ||
| }; | ||
| NetworkService::add_known_address( |
There was a problem hiding this comment.
Two questions:
- Why do we only need this when we want to connect to authorities?
- Don't we keep a DHT to resolve
PeerIds to addresses? I mean if we have them cached locally, it would be stupid to not use them, but it should still work if we did not - right?
rphmeier
added
the
D2-notlive 💤
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
rphmeier
added a commit
that referenced
this pull request
Mar 28, 2021
* Call NetworkService::add_known_address before sending a request * Better doc * Update Substrate * Update Substrate * Restore the import 🤷♀️ I don't know why it compiles locally * imports correctly Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires paritytech/substrate#8467 to be merged first. As is, this PR doesn't compile because of the missing function.
See the comment I added to
OutgoingRequest.Basically, you can't just call
send_request(OutgoingRequest::Peer(some_peer_id))and expect it to magically work, assc-networkmight have to establish a TCP connection but might not be aware of any address for that peer.This PR changes
Recipient::Authorityto pass the addresses fromsc-authority-discoverytosc-network.I've also removed the
peer_id_from_multiaddrfunction, because it does the same assc-network::config::parse_addr.