This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Override RuntimeApi::authorities() to include past sessions #2494
Merged
rphmeier
merged 5 commits into
paritytech:master
from
parity2305:return-past-authorityids
Feb 23, 2021
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
10b0b4a
override authorities runtime call
parity2305 21846f8
addressing feedback
ParthDesai 25c20f0
addressing feedback and restoring semantics
parity2305 0f2db99
updated helper function
parity2305 db6dc2b
naming convention + comment
parity2305 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this might be racy and error-prone at session boundaries, we can maybe iterate directly over the
Sessions
storage, but that's probably racy as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ordian At session boundary, If there is a race condition between getting session indexes above and loop execution, we might miss latest session's authority ids, which can break the semantics. So, to cover widest possible range here we can query session info from earliest..=current+1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fine at session boundaries as session changes are applied at the end of the parent block. The code comment in
fn session_index_for_child
is outdated and wrong and that threw me for a loop while investigating this comment.Iterating up to
current_session_index
is fine but we also want to include theAuthorityDiscovery::next_authorities
here. AlthoughAuthorityDiscovery
updates itscurrent
andnext
authorities at the beginning of the parent block, we are past the end of the parent block here andcurrent
should have made their way intoSessionInfo
.