Companion PR for substrate PR 8072 - Add a config field to babe epochs #2467

expenses · 2021-02-17T18:48:51Z

Companion PR for paritytech/substrate#8072.

…epoch

andresilva

Where is the initial EpochConfig being passed to BabeGenesisConfig? We can't just use the default value since this is currently configured with non-default values.

polkadot/runtime/polkadot/src/lib.rs

Lines 1236 to 1243 in 0409d12

    
           babe_primitives::BabeGenesisConfiguration { 
        
           	slot_duration: Babe::slot_duration(), 
        
           	epoch_length: EpochDuration::get(), 
        
           	c: PRIMARY_PROBABILITY, 
        
           	genesis_authorities: Babe::authorities(), 
        
           	randomness: Babe::randomness(), 
        
           	allowed_slots: babe_primitives::AllowedSlots::PrimaryAndSecondaryVRFSlots, 
        
           }

…epoch

runtime/rococo/src/lib.rs

runtime/westend/src/lib.rs

runtime/rococo/src/lib.rs

runtime/westend/src/lib.rs

runtime/kusama/src/lib.rs

…epoch

bkchr

This requires a runtime migration for the BABE pallet.

…epoch

Outdated

runtime/rococo/src/lib.rs

bkchr · 2021-03-05T17:07:31Z

runtime/kusama/src/lib.rs

 				genesis_authorities: Babe::authorities(),
 				randomness: Babe::randomness(),
-				allowed_slots: babe_primitives::AllowedSlots::PrimaryAndSecondaryVRFSlots,
+				allowed_slots: BABE_GENESIS_EPOCH_CONFIG.allowed_slots,


I assume this is only called at genesis?

@andresilva ?

Yes, that's fine. The migration has the correct value PrimaryAndSecondaryPlainSlots.

runtime/test-runtime/src/lib.rs

…epoch

runtime/kusama/src/lib.rs

ghost · 2021-03-10T08:40:35Z

Waiting for commit status.

ghost · 2021-03-10T08:45:41Z

Checks failed; merge aborted.

…adot into ashley-change-babe-epoch

…epoch

expenses · 2021-03-10T08:48:35Z

bot merge

ghost · 2021-03-10T08:48:38Z

Waiting for commit status.

ghost · 2021-03-10T08:54:15Z

Checks failed; merge aborted.

expenses · 2021-03-10T09:12:45Z

bot merge

ghost · 2021-03-10T09:12:49Z

Waiting for commit status.

Add a config field to babe epochs

37d0af2

expenses added B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. labels Feb 17, 2021

github-actions bot added the A0-please_review Pull request needs code review. label Feb 17, 2021

expenses mentioned this pull request Feb 17, 2021

Return babe configuration information in the babe api epoch functions paritytech/substrate#8072

Merged

expenses added 2 commits February 18, 2021 14:54

Merge remote-tracking branch 'origin/master' into ashley-change-babe-…

6aff871

…epoch

Fix test

e20860a

expenses added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Feb 18, 2021

expenses requested review from andresilva and shawntabrizi February 19, 2021 10:12

andresilva suggested changes Feb 22, 2021

View reviewed changes

expenses added 2 commits February 22, 2021 13:21

Merge remote-tracking branch 'origin/master' into ashley-change-babe-…

e99e958

…epoch

Add BABE_GENESIS_EPOCH_CONFIG consts

e752f11

paritytech-ci added the D2-breaksapi label Feb 22, 2021

expenses requested review from andresilva, rphmeier and bkchr February 22, 2021 12:53

andresilva reviewed Feb 23, 2021

View reviewed changes

runtime/rococo/src/lib.rs Outdated Show resolved Hide resolved

runtime/westend/src/lib.rs Outdated Show resolved Hide resolved

rphmeier reviewed Feb 23, 2021

View reviewed changes

runtime/rococo/src/lib.rs Outdated Show resolved Hide resolved

rphmeier reviewed Feb 23, 2021

View reviewed changes

runtime/westend/src/lib.rs Outdated Show resolved Hide resolved

rphmeier reviewed Feb 23, 2021

View reviewed changes

runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved

expenses added 2 commits February 24, 2021 12:13

Use PrimaryAndSecondaryVRFSlots and remove newlines

9f53c73

Merge remote-tracking branch 'origin/master' into ashley-change-babe-…

ca36203

…epoch

expenses requested review from andresilva and rphmeier February 24, 2021 11:17

bkchr previously requested changes Feb 24, 2021

View reviewed changes

expenses added 3 commits February 25, 2021 12:30

Merge remote-tracking branch 'origin/master' into ashley-change-babe-…

60e7e3f

…epoch

Make epoch_configs Some

316f242

Fix tests

9a436d8

Use PrimaryAndSecondaryPlainSlots in kusama

3c78c7a

expenses added B2-breaksapi and removed B0-silent Changes should not be mentioned in any release notes A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Mar 3, 2021

andresilva approved these changes Mar 5, 2021

View reviewed changes

bkchr reviewed Mar 5, 2021

View reviewed changes

Remove migration from test runtime and rococo

a9550e6

expenses requested a review from bkchr March 5, 2021 17:21

bkchr approved these changes Mar 5, 2021

View reviewed changes

expenses added 2 commits March 9, 2021 09:17

Merge remote-tracking branch 'origin/master' into ashley-change-babe-…

a467317

…epoch

Add HasPalletPrefix

1fdd426

expenses commented Mar 9, 2021

View reviewed changes

runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved

expenses and others added 2 commits March 9, 2021 12:19

Rename to BabePalletPrefix and change BabeApi -> Babe

8cf8910

"Update Substrate"

c21ae7d

expenses added 3 commits March 10, 2021 09:46

Update substrate

0072f6c

Merge branch 'ashley-change-babe-epoch' of github.com:paritytech/polk…

deea094

…adot into ashley-change-babe-epoch

Merge remote-tracking branch 'origin/master' into ashley-change-babe-…

c3a4fd3

…epoch

Resolve parantheses errors

c5a6cfb

ghost merged commit e6b065f into master Mar 10, 2021

ghost deleted the ashley-change-babe-epoch branch March 10, 2021 09:39

hackfisher mentioned this pull request Apr 22, 2021

Release 0.10.0 darwinia-network/darwinia#641

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Companion PR for substrate PR 8072 - Add a config field to babe epochs #2467

Companion PR for substrate PR 8072 - Add a config field to babe epochs #2467

expenses commented Feb 17, 2021

andresilva left a comment

bkchr left a comment

bkchr Mar 5, 2021

andresilva Mar 5, 2021

ghost commented Mar 10, 2021

ghost commented Mar 10, 2021

expenses commented Mar 10, 2021

ghost commented Mar 10, 2021

ghost commented Mar 10, 2021

expenses commented Mar 10, 2021

ghost commented Mar 10, 2021

	babe_primitives::BabeGenesisConfiguration {
	slot_duration: Babe::slot_duration(),
	epoch_length: EpochDuration::get(),
	c: PRIMARY_PROBABILITY,
	genesis_authorities: Babe::authorities(),
	randomness: Babe::randomness(),
	allowed_slots: babe_primitives::AllowedSlots::PrimaryAndSecondaryVRFSlots,
	}

Companion PR for substrate PR 8072 - Add a config field to babe epochs #2467

Companion PR for substrate PR 8072 - Add a config field to babe epochs #2467

Conversation

expenses commented Feb 17, 2021

andresilva left a comment

Choose a reason for hiding this comment

bkchr left a comment

Choose a reason for hiding this comment

bkchr Mar 5, 2021

Choose a reason for hiding this comment

andresilva Mar 5, 2021

Choose a reason for hiding this comment

ghost commented Mar 10, 2021

ghost commented Mar 10, 2021

expenses commented Mar 10, 2021

ghost commented Mar 10, 2021

ghost commented Mar 10, 2021

expenses commented Mar 10, 2021

ghost commented Mar 10, 2021