This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for substrate/pull/8113 (Unleash multi phase) #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…tion-provider-unleash-multi-phase
kianenigma
commented
Mar 13, 2021
kianenigma
commented
Mar 13, 2021
kianenigma
commented
Mar 13, 2021
kianenigma
commented
Mar 13, 2021
gui1117
reviewed
Mar 16, 2021
|
note that if we want to run benchmark on this PR we can do:
no ? |
gui1117
approved these changes
Mar 17, 2021
|
benchmarks needs to be run again once substrate PR is merged |
kianenigma
added
the
A4-companion
kianenigma
commented
Mar 19, 2021
| } | ||
|
|
||
| /// This is only for testing. The main migration is inside staking's `on_runtime_upgrade`. | ||
| pub struct KillOffchainPhragmenStorageTest; |
There was a problem hiding this comment.
This is just for testing, as the name suggests.
There was a problem hiding this comment.
does this mean it will be removed before merge?
if not maybe some extra module file would make sense
There was a problem hiding this comment.
I will remove it later, since I will probably want to test this one last time before enactment.
The migration is noop, rest assured it won't cause any issues.
kianenigma
commented
Mar 19, 2021
shawntabrizi
approved these changes
Mar 19, 2021
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
kianenigma
added
B7-runtimenoteworthy
C1-low
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
…m:paritytech/polkadot into kiz-election-provider-unleash-multi-phase
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
kianenigma
added
the
D1-audited 👍
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion for paritytech/substrate#8113