Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Cargo build step needs pre requisites not mentioned #2379

Merged
3 commits merged into from
Feb 4, 2021
Merged

Cargo build step needs pre requisites not mentioned #2379

3 commits merged into from
Feb 4, 2021

Conversation

saki-osive
Copy link
Contributor

The Cargo build step also needs the support software that's missing an immediate comment or indication for the same.

bkchr
bkchr approved these changes Feb 4, 2021
View reviewed changes
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 4, 2021
@bkchr
Copy link
Member

bkchr commented Feb 4, 2021

bot merge

@ghost
Copy link

ghost commented Feb 4, 2021

Waiting for commit status.

@ghost ghost merged commit 4866f8e into paritytech:master Feb 4, 2021
ordian added a commit that referenced this pull request Feb 4, 2021
@ordian
merge master
b1268aa 
* master:
  Unused variable can be ignored (#2381)
  End multiplexer stream once one of its inputs end. (#2380)
  Cargo build step needs pre requisites not mentioned (#2379)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saki-osive @bkchr