Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for 7822 (Remove _{} from benchmarks) #2202

Merged
2 commits merged into from
Jan 6, 2021
Merged

Companion PR for 7822 (Remove _{} from benchmarks) #2202

2 commits merged into from
Jan 6, 2021

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 5, 2021
@shawntabrizi shawntabrizi mentioned this pull request Jan 5, 2021
Merged
@ghost
Copy link

ghost commented Jan 6, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Jan 6, 2021

Merge failed: "At least 1 approving review is required by reviewers with write access."

jimmychu0807
jimmychu0807 approved these changes Jan 6, 2021
View reviewed changes
Copy link

@jimmychu0807 jimmychu0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dvdplm
Copy link
Contributor

dvdplm commented Jan 6, 2021

bot merge

@ghost
Copy link

ghost commented Jan 6, 2021

Trying merge.

@ghost ghost merged commit dbd9e9e into master Jan 6, 2021
@ghost ghost deleted the shawntabrizi-update-benchmarks-macro branch January 6, 2021 07:07
ordian added a commit that referenced this pull request Jan 6, 2021
@ordian
Merge branch 'master' into ao-7831-companion
58236e1 
* master:
  Bump trie-db from 0.22.1 to 0.22.2 (#2208)
  runtime: add Babe::next_epoch runtime api method (#2200)
  Bump pin-project from 1.0.2 to 1.0.3 (#2209)
  Companion PR for 7822 (Remove `_{}` from benchmarks) (#2202)
  Improve the `unbacked-span` (#2206)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@jimmychu0807 jimmychu0807 jimmychu0807 approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shawntabrizi @dvdplm @jimmychu0807 @paritytech-ci