Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make sure adder collator test is executed in CI #1949

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Make sure adder collator test is executed in CI #1949

merged 3 commits into from
Nov 12, 2020

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Nov 12, 2020

…overseer (#1947)"

This reverts commit 355558a.

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 12, 2020
ordian
ordian approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to accomplish what #1947 was trying to solve?
Namely, not run this test with cargo test --workspace --release?

@bkchr
Copy link
Member Author

bkchr commented Nov 12, 2020

We could change to the directory and run it directly. However this will probably require a huge rebuild and this will increase the already not so small CI time.

However, I don't expect this feature to last for that long and I added a comment to the test if it is failing to make the user aware that the feature needs to be activated.

@bkchr
Copy link
Member Author

bkchr commented Nov 12, 2020

And the test is also timing out after 10 minutes.

@bkchr
Copy link
Member Author

bkchr commented Nov 12, 2020

Okay, CI difference is below 2 minutes. Fine by me, we can keep this for now.

@bkchr bkchr changed the title Revert "Restrict collating_using_adder_collator test on feature real-… Make sure adder collator test is executed in CI Nov 12, 2020
@bkchr bkchr merged commit b19f3e1 into master Nov 12, 2020
@bkchr bkchr deleted the bkchr-bring-test-back branch November 12, 2020 18:48
ordian added a commit that referenced this pull request Nov 16, 2020
@ordian
Merge branch 'master' into ao-update-dependencies
bb1c419 
* master:
  Make sure adder collator test is executed in CI (#1949)
  Restrict collating_using_adder_collator test on feature real-overseer (#1947)
@ordian ordian mentioned this pull request Nov 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkchr @ordian