Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

XCM: Add the XCM primitives crate. #1760

Merged
1 commit merged into from
Sep 28, 2020
Merged

XCM: Add the XCM primitives crate. #1760

1 commit merged into from
Sep 28, 2020

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Sep 28, 2020 •
edited
Loading

Related to #1783

This is the first of many commits meant to land #1657 on master.

This is mostly verbatim except that all references to sp-runtime and sp-io are stripped. Now it is a plain old no-std crate.

@pepyakin @gavofyork
Add the XCM primitives crate.
fb59c79 
Co-authored-by: Gavin Wood <gavin@parity.io>
@pepyakin pepyakin added the A0-please_review Pull request needs code review. label Sep 28, 2020
@pepyakin pepyakin added this to the Grosvenor milestone Sep 28, 2020
@pepyakin pepyakin added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 28, 2020
shawntabrizi
shawntabrizi reviewed Sep 28, 2020
View reviewed changes
xcm/src/v0/mod.rs
///
/// Kind: *Trusted Indication*.
///
/// Errors:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep them if you don't mind, to save us work updating this now and later during rebasing while this doesn't seem to be actively harmful

@pepyakin
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Sep 28, 2020

Trying merge.

@ghost ghost merged commit ec55686 into master Sep 28, 2020
@ghost ghost deleted the ser-xcm-foundation branch September 28, 2020 14:28
ordian added a commit that referenced this pull request Sep 28, 2020
@ordian
Merge branch 'master' into ao-validator-discovery-api
9c5b654 
* master:
  Add the XCM primitives crate. (#1760)
  Register listeners in statement distribution (#1759)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
Grosvenor
Development

Successfully merging this pull request may close these issues.
2 participants
@pepyakin @shawntabrizi