This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
The Router Module #1679
Closed
The Router Module #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
added
A0-please_review
pepyakin
force-pushed
the
ser-first-messaging-changes
branch
4 times, most recently
from
ebeff82 to
b5e0c85
Compare
pepyakin
force-pushed
the
ser-first-messaging-changes
branch
10 times, most recently
from
f637148 to
e87cecd
Compare
pepyakin
force-pushed
the
ser-first-messaging-changes
branch
7 times, most recently
from
8f0eb50 to
5de6142
Compare
pepyakin
force-pushed
the
ser-first-messaging-changes
branch
4 times, most recently
from
43554ad to
1427dd1
Compare
This commit addresses the UMP part of #1869
This commit addresses the HRMP part of #1869
pepyakin
force-pushed
the
ser-first-messaging-changes
branch
from
1427dd1 to
8ff407e
Compare
|
Subsumed by #1900 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a placeholder PR that implements the router module, specifically UMP, DMP and HRMP. Along the way it updates the implementer's guide.
This PR has structured commits. Therefore:
Closes #1400
Closes #1663
Closes #1702
Closes #1704
Closes #1806
Closes #1869
Regarding #1663 I decided to go with a simple implementation: just to send a DM to notify paras. For now, it makes sense to start with a simpler approach to see how it works and then extend it as needed. My concern about this solution was that these notifications should be processed in a timely manner but a downward message queue can be clogged. Well, that's a bit too forward looking since most likely the queues won't be filled in the foreseeable future (assuming we can upgrade later). Apart from that, if that becomes an issue, it is possible for the PVF to enact messages out-of-order therefore getting some sort of QoS. But again I doubt that this will be required for now.
TODO