Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

implementers-guide: in TOC move collators before backing, to match protocol pipeline #1611

Merged
1 commit merged into from
Aug 18, 2020

Conversation

infinity0
Copy link
Contributor

No description provided.

@cla-bot-2020
Copy link

cla-bot-2020 bot commented Aug 18, 2020

@infinity0 it looks like you have not signed our contributor license aggreement yet. Please visit this link to sign our agreement. This pull request cannot be merged until the agrement is signed.

@cla-bot-2020
Copy link

cla-bot-2020 bot commented Aug 18, 2020

@infinity0, Your signature has been received.

@infinity0
Copy link
Contributor Author

CC @rphmeier

@infinity0
Copy link
Contributor Author

The failing CI tests say "[!] Release notes label not detected. Please add one of: B0-silent B1-releasenotes B7-runtimenoteworthy".

I'm not sure how to deal with this, but I guess someone else more familiar with this repo does?

@coriolinus coriolinus added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 18, 2020
@coriolinus
Copy link
Contributor

That's CI enforcing that every PR in the repo has a label from each of the A, B, and C categories. I took care of it for you.

@infinity0
Copy link
Contributor Author

@coriolinus Thanks. I don't see the option to add/remove labels here from my end, maybe I don't have the permissions to do so?

@ordian
Copy link
Member

ordian commented Aug 18, 2020

bot merge

@ghost
Copy link

ghost commented Aug 18, 2020

Waiting for commit status.

@ghost ghost merged commit c39fbd3 into paritytech:master Aug 18, 2020
@coriolinus
Copy link
Contributor

@infinity0 I can't say whether or not you have the permissions. What I can say is that, on the right-hand sidebar, if there is a gear icon by the labels row, then you can click that to edit the labels. If not, then you don't have the permissions.

ordian added a commit that referenced this pull request Aug 20, 2020
* master:
  Companion for Substrate #6815 (Dynamic Whitelist) (#1612)
  Candidate backing respects scheduled collator (#1613)
  implementers-guide: in TOC move collators before backing, to match protocol pipeline (#1611)
  Initial guide text for approvals and especially approvals assignments  (#1518)
  Implement validation data refactor (#1585)
  Implementer's Guide: Make HRMP use upward message kinds (#1591)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants