Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove v0 node-side parachains code #1609

Merged
8 commits merged into from
Aug 24, 2020
Merged

Remove v0 node-side parachains code #1609

8 commits merged into from
Aug 24, 2020

Conversation

rphmeier
Copy link
Contributor

This removes the following crates:

  • polkadot-network
  • polkadot-collator
  • polkadot-availability-store
  • (most of) polkadot-validation

polkadot-validation still remains as a simple stub that provides an empty set of candidates for inclusion in the set-heads inherent. Although v0 parachains runtime code was removed in #1501, there are still live networks (Polkadot, Kusama, Westend) which have it deployed, and they will require the set-heads inherent in order to proceed until a runtime upgrade enacts the removal on those networks.

At that point, we will be able to remove the polkadot-validation and polkadot-service crates entirely, replacing with v1 code.

@rphmeier rphmeier added A0-please_review Pull request needs code review. B1-releasenotes C3-medium PR touches the given topic and has a medium impact on builders. labels Aug 18, 2020
Copy link
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine at a fairly cursory glance. Agree that it looks like the validation stub should just provide an empty set of heads for every block.

@gavofyork
Copy link
Member

is the burnin happening?

(needs rebasing)

@rphmeier
Copy link
Contributor Author

@gavofyork Yeah, it has burned in on Westend and Kusama correctly.

@rphmeier
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Aug 24, 2020

Waiting for commit status.

@ghost ghost merged commit 00202d3 into master Aug 24, 2020
@ghost ghost deleted the rh-remove-v0-validation branch August 24, 2020 11:43
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C3-medium PR touches the given topic and has a medium impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants