This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Revert enabling authority discovery by default #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
andresilva
force-pushed
the
andre/disable-authority-discovery
branch
from
880ee8d
to
3bd081b
Compare
|
Do we still want this? |
bkchr
approved these changes
Aug 5, 2020
|
So what is the criteria for re-enabling authority-discovery again? For all we know it's working as intended, and I don't know what would need to change. |
ordian
added a commit
that referenced
this pull request
Aug 5, 2020
This was referenced Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1395.
The authority discovery module ends up consuming a very high amount of sockets which could lead to exhaustion of file descriptors.
Here's the difference on my local node with and without authority discovery enabled. On the left we can see peaks of >4k sockets and low is at ~1.5k. Without authority discovery we still see an initial peak (presumably due to regular DHT discovery) but the absolute number of sockets taken is an order of magnitude lower.