Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use substrate-wasm-builder-runner from substrate git #1343

Closed
wants to merge 2 commits into from
Closed

Use substrate-wasm-builder-runner from substrate git #1343

wants to merge 2 commits into from

Conversation

sorpaas
Copy link
Member

@sorpaas sorpaas commented Jul 2, 2020

This makes cargo vendor happier. Otherwise it will complain about duplicate versions of substrate-wasm-builder-runner and refuses to work.

@sorpaas sorpaas added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Jul 2, 2020
@bkchr
Copy link
Member

bkchr commented Jul 2, 2020

The correct approach would be to finally get rid of substrate test runtime that is pulled in. Then we should not pull in the dependency twice anymore.

@bkchr
Copy link
Member

bkchr commented Jul 2, 2020

#1118

@sorpaas sorpaas added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 2, 2020
@bkchr bkchr closed this Aug 2, 2020
@bkchr bkchr deleted the sp-cargo-vendor branch August 2, 2020 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorpaas @bkchr