Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Staking miner: Use at and solver in EmergencySolution #4678

Closed
kianenigma opened this issue Jan 10, 2022 · 1 comment
Closed

Staking miner: Use at and solver in EmergencySolution #4678

kianenigma opened this issue Jan 10, 2022 · 1 comment
Assignees

Comments

@kianenigma
Copy link
Contributor

as the dead_code annotation indicates, these two are currently not being used: https://github.com/paritytech/polkadot/blob/634f649bac6abafe97f95663238a62d0bc17b640/utils/staking-miner/src/main.rs#L319-322

The emergency solution code should also use these two parameters when generating a solution. Look into how DryRunConfig is using these for inspiration.

@niklasad1
Copy link
Member

Fixed by #4694

niklasad1 added a commit that referenced this issue Feb 7, 2022
* staking miner: use config for emergency solution

Fixes #4678

* bump jsonrpsee

* run `monitor_cmd_for` until the connection is closed

* new tokio task for submit_and_watch xt

* re-use header subscription

* update jsonrpsee + simplify code

* revert polkadot runtime changes

* fix grumbles

* Update utils/staking-miner/src/monitor.rs

* grumbles: fix logs + nits
paritytech-processbot bot pushed a commit that referenced this issue Feb 18, 2022
* staking miner: use config for emergency solution

Fixes #4678

* bump jsonrpsee

* run `monitor_cmd_for` until the connection is closed

* new tokio task for submit_and_watch xt

* re-use header subscription

* update jsonrpsee + simplify code

* revert polkadot runtime changes

* fix grumbles

* Update utils/staking-miner/src/monitor.rs

* staking miner: reuse ws conn for remote-ext

* Revert "revert polkadot runtime changes"

This reverts commit 5fddbbe.

* cargo fmt

* revert unintentional change

* revert unintentional change

* add type SharedRpcClient

* cargo fmt

* fix nits

* spelling

* use tracing_subcriber and cleanup

* remove some needless clones

* fix some nits

* fix spellcheck
paritytech-processbot bot pushed a commit that referenced this issue Mar 4, 2022
* staking miner: use config for emergency solution

Fixes #4678

* bump jsonrpsee

* run `monitor_cmd_for` until the connection is closed

* new tokio task for submit_and_watch xt

* re-use header subscription

* update jsonrpsee + simplify code

* revert polkadot runtime changes

* feat: add `ensure_no_better_solution` function

* storage access for submissions and indices

* check ensure_no_previous_solution before remote ext

* fix todos

* grumbles: Perbill::from_percent

* hacky fix

* use modified EPM pallet and various fixes

* diener update --substrate --branch na-epm-pub

* Revert "diener update --substrate --branch na-epm-pub"

This reverts commit b3b9a58.

* update substrate

* tokio spawn on concurrent stuff

* cleanup

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/monitor.rs

* more cleanup

* fix nits

* address grumbles

* only run batch reqs when signed phase

* better help menu for submission strategy CLI

* add tests for submission strategy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants