Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Max block size should be a limit in the runtime configuration #1572

Closed
rphmeier opened this issue Aug 12, 2020 · 0 comments · Fixed by #1984
Closed

Max block size should be a limit in the runtime configuration #1572

rphmeier opened this issue Aug 12, 2020 · 0 comments · Fixed by #1984
Assignees
@coriolinus
Labels
I8-refactor Code needs refactoring.
Milestone
Grosvenor

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Aug 12, 2020 •
edited
Loading

The CandidateValidation subsystem expects to have a local max_block_data_size which the underlying Wasm validation logic should use to do checks. This value should instead be drawn from the chain itself.

This should either be added as a separate runtime API or added to the ValidationData (see #1539), probably as Persisted
@rphmeier rphmeier added the I8-refactor Code needs refactoring. label Aug 12, 2020
@rphmeier rphmeier added this to the Grosvenor milestone Aug 12, 2020
@coriolinus coriolinus self-assigned this Nov 19, 2020
coriolinus added a commit that referenced this issue Nov 19, 2020
@coriolinus
add max_pov_size to runtime config and PersistedValidationData
f6f238a 
Closes #1572.
@coriolinus coriolinus mentioned this issue Nov 19, 2020
Merged
rphmeier pushed a commit that referenced this issue Nov 19, 2020
@coriolinus
add max_pov_size to runtime config and PersistedValidationData (#1984)
6376b57 
* add max_pov_size to runtime config and PersistedValidationData

Closes #1572.

* set default genesis max_pov_size

* apply suggestions from code review

* add default max_pov_size to polkadot_testnet_genesis
@pepyakin pepyakin mentioned this issue Dec 7, 2020
Open
@s0me0ne-unkn0wn s0me0ne-unkn0wn mentioned this issue Sep 28, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@coriolinus coriolinus

Labels
I8-refactor Code needs refactoring.
Projects
None yet
Milestone
Grosvenor
Development

Successfully merging a pull request may close this issue.

add max_pov_size to runtime config and PersistedValidationData paritytech/polkadot
2 participants
@coriolinus @rphmeier