Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings #7507

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Fix compilation warnings #7507

merged 4 commits into from
Feb 7, 2025

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Feb 7, 2025

This should fix some compilation warnings discovered under rustc 1.83

@pgherveou pgherveou requested a review from a team as a code owner February 7, 2025 08:57
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 7, 2025 08:58
@pgherveou pgherveou changed the title Fix compilation warnings Fix compilation warnings Feb 7, 2025
@pgherveou
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@pgherveou pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-silent Changes should not be mentioned in any release notes and removed T7-smart_contracts This PR/Issue is related to smart contracts. labels Feb 7, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13196530428
Failed job name: test-linux-stable

return Some(grandpa_info)
}
None
let Event::<T, I>::UpdatedBestFinalizedHeader { grandpa_info, .. } =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to compile correctly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah looks like this does not compile on the current version

prdoc/pr_7507.prdoc Outdated Show resolved Hide resolved
@pgherveou pgherveou enabled auto-merge February 7, 2025 14:44
@pgherveou pgherveou added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@bkchr bkchr added this pull request to the merge queue Feb 7, 2025
Merged via the queue into master with commit 49e381a Feb 7, 2025
207 of 209 checks passed
@bkchr bkchr deleted the pg/fix-warnings branch February 7, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants