Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pallet-revive] fix eth-rpc indexing #7493

Merged
merged 27 commits into from
Feb 7, 2025
Merged

[pallet-revive] fix eth-rpc indexing #7493

merged 27 commits into from
Feb 7, 2025

Conversation

pgherveou
Copy link
Contributor

  • Fix a deadlock on the RWLock cache
  • Remove eth-indexer, we won't need it anymore, the indexing will be started from within eth-rpc directly

@pgherveou pgherveou requested review from a team as code owners February 6, 2025 09:09
@pgherveou
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@pgherveou pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-silent Changes should not be mentioned in any release notes labels Feb 6, 2025
nprt
nprt approved these changes Feb 6, 2025
View reviewed changes
Copy link

@nprt nprt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming it fixes an issue with a local Blockscout setup, related to batched block querying.

athei
athei approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Less binaries less problems.

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13181921670
Failed job name: test-linux-stable

Base automatically changed from pg/fix-eth-fee-rpc to master February 7, 2025 14:06
@pgherveou pgherveou enabled auto-merge February 7, 2025 14:45
@pgherveou pgherveou added this pull request to the merge queue Feb 7, 2025
Merged via the queue into master with commit 4ec221e Feb 7, 2025
204 of 207 checks passed
@pgherveou pgherveou deleted the pg/fix-rpc-dead-lock branch February 7, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athei athei athei approved these changes

@xermicus xermicus xermicus approved these changes

@alvicsam alvicsam alvicsam approved these changes

@nprt nprt nprt approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pgherveou @athei @xermicus @alvicsam @nprt