Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridges small nits/improvements #7383

Merged
merged 9 commits into from
Jan 29, 2025
Merged

Bridges small nits/improvements #7383

merged 9 commits into from
Jan 29, 2025

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jan 29, 2025

This PR contains small fixes and backwards compatibility issues identified during work on the larger PR: #6906.

@bkontur bkontur added the T15-bridges This PR/Issue is related to bridges. label Jan 29, 2025
@bkontur bkontur self-assigned this Jan 29, 2025
@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 29, 2025 11:14
@bkontur
Copy link
Contributor Author

bkontur commented Jan 29, 2025

/cmd fmt

@bkontur
Copy link
Contributor Author

bkontur commented Jan 29, 2025

/cmd prdoc --audience runtime_dev --bump patch

@bkontur bkontur added the A4-needs-backport Pull request must be backported to all maintained releases. label Jan 29, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13030780875
Failed job name: run-frame-omni-bencher

bkontur
bkontur commented Jan 29, 2025
View reviewed changes
prdoc/pr_7383.prdoc Outdated Show resolved Hide resolved
@bkontur bkontur enabled auto-merge January 29, 2025 13:12
@bkontur bkontur added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit ada12be Jan 29, 2025
205 of 209 checks passed
@bkontur bkontur deleted the bko-bridges-nits branch January 29, 2025 15:06
@paritytech-cmd-bot-polkadot-sdk
Copy link

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7383-to-stable2407
git worktree add --checkout .worktree/backport-7383-to-stable2407 backport-7383-to-stable2407
cd .worktree/backport-7383-to-stable2407
git reset --hard HEAD^
git cherry-pick -x ada12be652a4fa8f60fc54e8cfe9ca81e09ad28b
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 29, 2025
Closed
@paritytech-cmd-bot-polkadot-sdk
Copy link

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7383-to-stable2409
git worktree add --checkout .worktree/backport-7383-to-stable2409 backport-7383-to-stable2409
cd .worktree/backport-7383-to-stable2409
git reset --hard HEAD^
git cherry-pick -x ada12be652a4fa8f60fc54e8cfe9ca81e09ad28b
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 29, 2025
Merged
@paritytech-cmd-bot-polkadot-sdk
Copy link

Created backport PR for stable2412:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7383-to-stable2412
git worktree add --checkout .worktree/backport-7383-to-stable2412 backport-7383-to-stable2412
cd .worktree/backport-7383-to-stable2412
git reset --hard HEAD^
git cherry-pick -x ada12be652a4fa8f60fc54e8cfe9ca81e09ad28b
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 29, 2025
Merged
bkontur added a commit that referenced this pull request Jan 29, 2025
@bkontur
Bridges small nits/improvements (#7383)
e06d981 
This PR contains small fixes and backwards compatibility issues
identified during work on the larger PR:
#6906.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit ada12be)
bkontur added a commit that referenced this pull request Jan 29, 2025
@bkontur
Bridges small nits/improvements (#7383)
1908ab4 
This PR contains small fixes and backwards compatibility issues
identified during work on the larger PR:
#6906.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit ada12be)
ordian added a commit that referenced this pull request Feb 3, 2025
@ordian
Merge branch 'master' into ao-migrate-zombie-past-slashing-test
83a2992 
* master:
  Remove warnings by cleaning up the `Cargo.toml` (#7416)
  [Backport] Version bumps from stable2412-1 + prdocs reorg (#7401)
  fix pre-dispatch PoV underweight for ParasInherent (#7378)
  malus-collator: implement malicious collator submitting same collation to all backing groups (#6924)
  `fatxpool`: use tracing for logging (#6897)
  Improvements for Weekly bench (#7390)
  Replace derivative dependency with derive-where (#7324)
  Add support for feature `pallet_balances/insecure_zero_ed` in benchmarks and testing (#7379)
  Fix Snowbridge benchmark tests (#7296)
  Bridges small nits/improvements (#7383)
  Migrating cumulus-pallet-session-benchmarking to Benchmarking V2  (#6564)
  [pallet-revive] implement the block author API  (#7198)
  Use checked math in frame-balances named_reserve (#7365)
  move installation of frame-omni-bencher into a cmd.py itself (#7372)
  remove old bench & revert the frame-weight-template (#7362)
  ci: fix workflow permissions (#7366)
  [net/libp2p] Use raw `Identify` observed addresses to discover external addresses (#7338)
  Improve `set_validation_data` error message. (#7359)
  Implement pallet view function queries (#4722)
EgorPopelyaev pushed a commit that referenced this pull request Feb 4, 2025
@paritytech-cmd-bot-polkadot-sdk @bkontur
[stable2409] Backport #7383 (#7392)
5628190 
Backport #7383 into `stable2409` from bkontur.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
EgorPopelyaev pushed a commit that referenced this pull request Feb 4, 2025
@paritytech-cmd-bot-polkadot-sdk @bkontur
[stable2412] Backport #7383 (#7393)
9de8837 
Backport #7383 into `stable2412` from bkontur.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Ank4n pushed a commit that referenced this pull request Feb 6, 2025
@bkontur @github-actions @Ank4n
Bridges small nits/improvements (#7383)
74486e5 
This PR contains small fixes and backwards compatibility issues
identified during work on the larger PR:
#6906.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@acatangiu acatangiu acatangiu approved these changes

@raymondkfcheung raymondkfcheung raymondkfcheung approved these changes

Assignees

@bkontur bkontur

Labels
A4-needs-backport Pull request must be backported to all maintained releases. T15-bridges This PR/Issue is related to bridges.
Projects
Bridges + XCM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkontur @franciscoaguirre @acatangiu @raymondkfcheung