Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Revert "[Staking] Currency <> Fungible migration" #7269

Conversation

pepoviola
Copy link
Contributor

Reverts #5501

@pepoviola pepoviola requested review from acatangiu and a team as code owners January 20, 2025 23:38
@pepoviola pepoviola added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. labels Jan 20, 2025
@gui1117
Copy link
Contributor

gui1117 commented Jan 21, 2025

What is the context?

@bkchr
Copy link
Member

bkchr commented Jan 21, 2025

What is the context?

This fixes a zombienet test that broke because of this pr.

@Ank4n can you please work with @pepoviola to fix the test?

@Ank4n
Copy link
Contributor

Ank4n commented Jan 21, 2025

What is the context?

This fixes a zombienet test that broke because of this pr.

@Ank4n can you please work with @pepoviola to fix the test?

Yes. This might be because the tests (at genesis) are attempting to stake all the funds in an account.
After #5501, we need to ensure that at least the ED remains as free balance in the account.

DM'ing you @pepoviola.

@pepoviola
Copy link
Contributor Author

Closing here, fixed here. I will release a new version and bump it here.

Thanks @Ank4n / @bkchr!

@pepoviola pepoviola closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants