Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor command bot and drop rejecting non paritytech members #7231

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

mordamax
Copy link
Contributor

@mordamax mordamax commented Jan 18, 2025

Aims to

What's changed:

  • removed is paritytech member check as required prerequisite to run a command
  • run the cmd.py script taking it from master, if someone who run this is not a member of paritytech, and from current branch, if is a member. That keeps the developer experience & easy testing if paritytech members are contributing to cmd.py
  • isolate the cmd job from being able to access GH App token or PR token- currently the fmt/bench/prdoc are being run with limited permissions scope, just to generate output, which then is uploaded to artifacts, and then the other job which doesn't run any files from repo, does a commit/push more securely

@mordamax mordamax added the R0-silent Changes should not be mentioned in any release notes label Jan 19, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12906645216
Failed job name: test-linux-stable

@pavelsupr pavelsupr self-requested a review January 22, 2025 16:31
@mordamax mordamax marked this pull request as ready for review January 22, 2025 18:43
@mordamax mordamax requested review from a team as code owners January 22, 2025 18:43
@mordamax mordamax changed the title Refactor command bot and drop membership check Refactor command bot and drop membership check required Jan 22, 2025
@mordamax mordamax changed the title Refactor command bot and drop membership check required Refactor command bot and drop rejecting non paritytech members Jan 22, 2025
@mordamax mordamax added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit 6091330 Jan 23, 2025
200 of 204 checks passed
@mordamax mordamax deleted the mak-cmd-for-people branch January 23, 2025 14:03
@bkchr
Copy link
Member

bkchr commented Jan 23, 2025

Nice work @mordamax :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd-bot for the people! /cmd bench with all runtimes fails
5 participants