Pallet:Auction move tests and benchmark to seperate files #6746
+2,038
−1,980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krayt78
changed the title
shawntabrizi
reviewed
Dec 5, 2024
shawntabrizi
reviewed
Dec 5, 2024
shawntabrizi
reviewed
Dec 5, 2024
shawntabrizi
reviewed
Dec 5, 2024
shawntabrizi
reviewed
Dec 6, 2024
shawntabrizi
approved these changes
Dec 6, 2024
shawntabrizi
added
the
R0-silent
gui1117
previously approved these changes
Dec 18, 2024
|
We can resolve merge conflicts, then I can approve |
Struggling with git rn, will redo the PR with the conflict resolved |
|
Merge issue has been fixed in this PR : #6942 |
|
can you force push? |
Krayt78
force-pushed
the
Improve-pallet-auctions-file-structure
branch
from
8b2e6df to
03cf2fa
Compare
thx a lot ! Rly need to learn the cli shenanigans instead of relying on github desktop ^^ |
shawntabrizi
added
R0-silent
gui1117
approved these changes
Dec 19, 2024
Merged
via the queue into
paritytech:master
with commit Dec 19, 2024
0de6854
245 of 257 checks passed
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
…#6746) # Description Linked to issue paritytech#590. I moved the tests and benchmarking to their own seperate file to reduce the bloat inside auctions.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked to issue #590.
I moved the tests and benchmarking to their own seperate file to reduce the bloat inside auctions.rs