Update pallet society to support Block Number Provider #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you help review this too @gui1117 |
gui1117
reviewed
Dec 2, 2024
This was referenced Jan 14, 2025
muharem
approved these changes
Jan 24, 2025
prdoc/pr_6623.prdoc
Outdated
| - audience: Runtime Dev | ||
| description: | | ||
| This PR makes the block number provider used in the society pallet configurable. Before this PR, society pallet always used the system block number, | ||
| with this PR some runtime can opt to use the relay chain block number instead. |
There was a problem hiding this comment.
For the PRs with block provider, I would try to leave a comment for a user that to keep everything as is they just need to set it to System. With just the current description I would still want to understand why, and what should I set.
…_block_number_provider
Merged
via the queue into
paritytech:master
with commit Feb 7, 2025
fddb6a2
202 of 205 checks passed
|
/tip small |
|
@ggwpez A referendum for a small (20 DOT) tip was successfully submitted for @dharjeezy (12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW on polkadot). Referendum number: 1430. |
|
The referendum has appeared on Polkassembly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces BlockNumberProvider config for pallet society.
closes part of #6297
Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW