[CI] Skip SemVer on R0-silent and update docs #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
alvicsam
approved these changes
Oct 30, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
removed
the
R0-silent
This reverts commit 2285948.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
mordamax
reviewed
Nov 4, 2024
| @@ -117,7 +133,7 @@ def setup_parser(parser=None, pr_required=True): | |||
| parser = argparse.ArgumentParser() | |||
| parser.add_argument("--pr", type=int, required=pr_required, help="The PR number to generate the PrDoc for.") | |||
| parser.add_argument("--audience", type=str, nargs='*', choices=allowed_audiences, default=["todo"], help="The audience of whom the changes may concern. Example: --audience runtime_dev node_dev") | |||
There was a problem hiding this comment.
nit: may be worth moving the audience map into separate var in this scope, so the allowed_audiences could be formed dynamically out of aliases keys?
mordamax
approved these changes
Nov 4, 2024
EgorPopelyaev
approved these changes
Nov 4, 2024
bkchr
reviewed
Nov 5, 2024
| @@ -61,21 +61,29 @@ jobs: | |||
|
|
|||
| echo "PRDOC_EXTRA_ARGS=--max-bump minor" >> $GITHUB_ENV | |||
|
|
|||
| - name: Echo Skip | |||
There was a problem hiding this comment.
If you move the "comment if backport" to an extra job, you would only need to write one if for the entire job.
|
Going to merge now as i dont want to test additional changes again, it takes a lot of time to test this in an example repo. |
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
Changes: - Make R0-silent not run the semver check again. Originally I thought this would be good to have a bullet-proof check, but it now often triggers when CI or unrelated files are changed. In the end, the developer has to make the right choice here - and always will need to. So bringing back the R0 label gives more power to the devs and should increase dev velocity. We still need to ensure that every use of this label is well understood, and not just used out of lazyness. - Fix `/cmd prdoc` bump levels - Update docs --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ordian
added a commit
that referenced
this pull request
Jan 7, 2025
* master: (256 commits) fix chunk fetching network compatibility zombienet test (#6988) chore: delete repeat words (#7034) Print taplo version in CI (#7041) Implement cumulus StorageWeightReclaim as wrapping transaction extension + frame system ReclaimWeight (#6140) Make `TransactionExtension` tuple of tuple transparent for implication (#7028) Replace duplicated whitelist with whitelisted_storage_keys (#7024) [WIP] Fix networking-benchmarks (#7036) [docs] Fix release naming (#7032) migrate pallet-mixnet to umbrella crate (#6986) Improve remote externalities logging (#7021) Fix polkadot sdk doc. (#7022) Remove warning log from frame-omni-bencher CLI (#7020) [pallet-revive] fix file case (#6981) Add workflow for networking benchmarks (#7029) [CI] Skip SemVer on R0-silent and update docs (#6285) correct path in cumulus README (#7001) sync: Send already connected peers to new subscribers (#7011) Excluding chainlink domain for link checker CI (#6524) pallet-bounties: Fix benchmarks for 0 ED (#7013) Log peerset set ID -> protocol name mapping (#7005) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
/cmd prdocbump levels