Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowbridge V2 docs #5902
Snowbridge V2 docs #5902
Changes from 2 commits
53272b6
86d9c29
6c8df9b
3bd696c
d0521bd
b21e5be
495ab69
dc7d01a
791aaf3
1c0c9f0
b098f43
b90b07d
7f10dd4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These rates are obtained off-chain and the total fee might be too low if the rates were wrong and beta not enough to cover the difference, right?
I might add a little note here to highlight the importance of getting the correct exchange rates and the consequence of not having them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you previously stated
$P^{'}$
and$E^{'}$
were the native currency of Polkadot and Ethereum respectively, should those be used here? Or should we just use DOT and ETH throughout?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mathematical notation was useful for distilling the essence of the algorithm. However I've made it more clear in 495ab69 that DOT and ETH are alternative names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
m
unique? In order for this to identify the message and not just a command that can repeat itself. I think there was a nonce, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
o
has to be the sameu
as described previously, right? That way we know they're able to claim these rewards. I'd add that here if that's the case.