zombienet, retry only on 'runner_system_failure'
#5882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepoviola
added
R0-silent
alvicsam
approved these changes
Oct 1, 2024
|
@pepoviola can you explain what this brings us? |
Yes, the idea is to only retry automatically the jobs that fail at setup stage (e.g. the runner fail to be created) and do not retry in other stage, this will give us more visibility of fails in zombienet tests and we can act on them (fix/disable). Currently we are always retrying (2 times). I can adjust this settings if you think is better to have some retries. Update: This also bump the version of zombienet (some fixes related to ci). |
bkchr
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only retry jobs on
runner_system_failure.Thx!