Migrated docs scripts to GitHub actions
#5345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bullrich
added
the
R0-silent
Bullrich
force-pushed
the
ci/gha-migration/docs
branch
2 times, most recently
from
a65a89c to
597a659
Compare
alvicsam
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Nice work! A few changes needed to save consistency across workflows and to use forklift. Also I'd like to explain why I altered needs: in some jobs. test-doc is the longest one so it should run right after set-image. While it runs two other jobs (build-rustdoc and test-rustdoc) can run sequentially.
Bullrich
force-pushed
the
ci/gha-migration/docs
branch
from
0fcd717 to
4823e58
Compare
|
Thank you for your thorough review @alvicsam. I have applied or your suggestion and set the environment to push. |
alvicsam
approved these changes
Aug 14, 2024
Bullrich
force-pushed
the
ci/gha-migration/docs
branch
2 times, most recently
from
ef8733d to
61f905b
Compare
Bullrich
force-pushed
the
ci/gha-migration/docs
branch
2 times, most recently
from
c2fe3f0 to
f6fdd4d
Compare
mordamax
approved these changes
Aug 20, 2024
I did it with chatgpt tho, so I need to test it
It could be too troublesome
The ref name changes based on being running on `push` or `pull_request` event
Applied fixes by @alvicsam Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Not only when the PR is labeled
this way if a new commit is pushed the old action will be stopped. It will only happen in PRs and not in the master branch
Bullrich
force-pushed
the
ci/gha-migration/docs
branch
from
f6fdd4d to
389debf
Compare
Merged
via the queue into
paritytech:master
with commit Aug 20, 2024
717bbb2
181 of 184 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated the following scripts to GHA
masteris modified)Resolves paritytech/ci_cd#1016
Some questions I have:
gitlab-cifiles?