-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Pallet UI doc test #5264
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry 😅
The test was flaky because it became out of sync with the README it was testing against? |
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
CI/CD team is investigating if its a caching issue since it included a file from a different crate (which is possibly incorrectly cached). But it should have normally not failed. This MR just fixes the behaviour of using a real readme and uses testing readmes from the same crate instead. |
The CI pipeline was cancelled due to failure one of the required jobs. |
Interesting, my grammar nits have accidentally repeated the issue but within the same package. Looks like the docs cache is refreshed but not the cache of the package itself (if I'm interpreting the diff properly (?)) |
Yea, or the CI was started in between two commits where i applied your suggestions. Going to restart and wait. PS: Another typo |
Test currently failing, therefore improving to include a file from the same crate to not trip up the caching. R0 silent since this is only modifying unpublished crates. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Dónal Murray <donal.murray@parity.io>
Test currently failing, therefore improving to include a file from the same crate to not trip up the caching.
R0 silent since this is only modifying unpublished crates.