Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XcmPaymentApi and DryRunApi on all system parachains #4634

Merged
merged 28 commits into from
May 31, 2024

Conversation

franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented May 29, 2024

Depends on #4621.

Implemented the XcmPaymentApi and DryRunApi on all system parachains.

More scenarios can be tested on both rococo and westend if all system parachains implement this APIs.
The objective is for all XCM-enabled runtimes to implement them.
After demonstrating fee estimation in a UI on the testnets, come the fellowship runtimes.

Step towards #690.

@franciscoaguirre franciscoaguirre marked this pull request as ready for review May 29, 2024 16:30
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label May 29, 2024
Base automatically changed from xcm-dry-run-call to master May 29, 2024 20:23
@paritytech-ci paritytech-ci requested a review from a team as a code owner May 29, 2024 20:23
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@acatangiu acatangiu requested a review from a team May 31, 2024 09:08
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit: query_acceptable_payment_assets and query_weight_to_asset_fee have some logic (converting, matching and logging) and since it'll propagate to another 8+ chains in the future (meaning DotSama), maybe it worth to add that implementation to some crate instead of copying the same code over and over. Ideally it should be just one liner :)

@franciscoaguirre
Copy link
Contributor Author

One nit: query_acceptable_payment_assets and query_weight_to_asset_fee have some logic (converting, matching and logging) and since it'll propagate to another 8+ chains in the future (meaning DotSama), maybe it worth to add that implementation to some crate instead of copying the same code over and over. Ideally it should be just one liner :)

Good point, if we had a good config item on pallet-xcm that gave us what we need I could de-duplicate very easily. However, that's not the case. I can make one in the future. For now, I managed to get query_acceptable_payment_assets to be shorter. For query_weight_to_asset_fee I'll make one in a future PR so this can be merged.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6365615

@franciscoaguirre franciscoaguirre added this pull request to the merge queue May 31, 2024
Merged via the queue into master with commit fc6c318 May 31, 2024
154 of 157 checks passed
@franciscoaguirre franciscoaguirre deleted the impl-xcm-apis-everywhere branch May 31, 2024 16:04
ordian added a commit that referenced this pull request Jun 4, 2024
* master: (106 commits)
  [ci] Delete unused flow (#4676)
  Fix umbrella CI check and fix the C&P message (#4670)
  Add Dockerfiles to the templates (#4637)
  Revamp the Readme of the minimal template (#4649)
  Add chain-spec-builder docker image (#4655)
  Update Amforc bootnodes for Kusama and Polkadot (#4668)
  make all storage items in parachain-system public (#4645)
  [Pools] Refactors and runtime apis for DelegateStake (#4537)
  update amforc westend and its parachain bootnodes (#4641)
  Better error for missing index in CRV2 (#4643)
  Implement `XcmPaymentApi` and `DryRunApi` on all system parachains (#4634)
  Use Unlicense for templates (#4628)
  collator-protocol: remove `elastic-scaling-experimental` feature (#4595)
  Update `runtime_type` ref doc with the new "Associated Type Bounds" (#4624)
  Adds ability to specify chain type in chain-spec-builder (#4542)
  Fix broken windows build (#4636)
  Beefy client generic on aduthority Id (#1816)
  pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620)
  Broker new price adapter (#4521)
  Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621)
  ...
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
…aritytech#4634)

Depends on paritytech#4621.

Implemented the
[`XcmPaymentApi`](paritytech#3607)
and [`DryRunApi`](paritytech#3872)
on all system parachains.

More scenarios can be tested on both rococo and westend if all system
parachains implement this APIs.
The objective is for all XCM-enabled runtimes to implement them.
After demonstrating fee estimation in a UI on the testnets, come the
fellowship runtimes.

Step towards paritytech#690.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
…aritytech#4634)

Depends on paritytech#4621.

Implemented the
[`XcmPaymentApi`](paritytech#3607)
and [`DryRunApi`](paritytech#3872)
on all system parachains.

More scenarios can be tested on both rococo and westend if all system
parachains implement this APIs.
The objective is for all XCM-enabled runtimes to implement them.
After demonstrating fee estimation in a UI on the testnets, come the
fellowship runtimes.

Step towards paritytech#690.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants