Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split polkadot parachains service file into multiple modules #4369

Closed
wants to merge 13 commits into from
Closed

Split polkadot parachains service file into multiple modules #4369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5b175ae
move service to service/mod.rs
clangenb May 3, 2024
6541297
refactor some stuff into service/core and service/start_node
clangenb May 3, 2024
9df9555
refactor more stuff into service/core and service/start_node
clangenb May 3, 2024
58beadf
fix warnings with cargo fix -p polkadot-parachain-bin
clangenb May 3, 2024
978c0fd
fix more warnings
clangenb May 3, 2024
d2694ff
rename core to consensus
clangenb May 3, 2024
0fcf98d
improve some import paths and fmt
clangenb May 3, 2024
026cd3f
add license headers
clangenb May 3, 2024
dfbcb9c
extract rpc_extensions
clangenb May 3, 2024
2430ed5
extract new_partial, and start_node_impl.rs to separate files
clangenb May 3, 2024
180e1d5
introduce common types module
clangenb May 3, 2024
256fbe8
cleanup
clangenb May 3, 2024
c230b71
fmt
clangenb May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cumulus/polkadot-parachain/src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ use crate::{
fake_runtime_api::{
asset_hub_polkadot_aura::RuntimeApi as AssetHubPolkadotRuntimeApi, aura::RuntimeApi,
},
service::{new_partial, Block, Hash},
service::{
common_types::{Block, Hash},
new_partial,
},
};
use cumulus_client_service::storage_proof_size::HostFunctions as ReclaimHostFunctions;
use cumulus_primitives_core::ParaId;
Expand Down
2 changes: 1 addition & 1 deletion cumulus/polkadot-parachain/src/rpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

use std::sync::Arc;

use parachains_common::{AccountId, Balance, Block, Nonce};
use crate::service::common_types::{AccountId, Balance, Block, Nonce};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this should maybe be at the crate root now that I look at it.

use sc_client_api::AuxStore;
pub use sc_rpc::DenyUnsafe;
use sc_transaction_pool_api::TransactionPool;
Expand Down
Loading