[BEEFY] Return valid signatures when verifying commitment #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
R0-silent
|
The CI pipeline was cancelled due to failure one of the required jobs. |
svyatonik
approved these changes
Apr 24, 2024
acatangiu
approved these changes
Apr 24, 2024
Merged
via the queue into
paritytech:master
with commit Apr 24, 2024
8dc0b33
138 of 140 checks passed
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to split parts of the #1903 into smaller PRs
For #1903 it would help if
verify_with_validator_set()returned the list of valid authority-signatures pairs, since after the verification we need to send them in the equivocation proof.