[subsystem-benchmark] Add approval-voting benchmark to CI #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvicsam
approved these changes
Apr 19, 2024
AndWeHaveAPlan
approved these changes
Apr 19, 2024
AndreiEres
added
R0-silent
sandreim
approved these changes
Apr 20, 2024
| // You should have received a copy of the GNU General Public License | ||
| // along with Polkadot. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| // TODO |
| // TODO | ||
| //! approval-voting throughput test | ||
| //! | ||
| //! Approval Voting benchmark based on Kusama parameters and scale. |
There was a problem hiding this comment.
These are future parameters, we're not there yet, but hopefully we'll be there soon.
| let mut messages = vec![]; | ||
| let mut config = TestConfiguration::default(); | ||
| // A single node effort roughly | ||
| config.n_cores = 100; |
There was a problem hiding this comment.
Are we approving 100 candidates per block ? If so, then the comment above is not correct.
There was a problem hiding this comment.
Yes, this would generate assignments and approvals for 100 occupied core each block
alexggh
approved these changes
Apr 22, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.