parachains_coretime: Expose MaxXCMTransactWeight
#4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be configured on the runtime level and not somewhere inside the pallet.
bkchr
added
the
T8-polkadot
bkontur
reviewed
Apr 18, 2024
acatangiu
approved these changes
Apr 18, 2024
seadanda
reviewed
Apr 18, 2024
polkadot/runtime/westend/src/lib.rs
Outdated
| @@ -1188,6 +1188,7 @@ impl parachains_scheduler::Config for Runtime { | |||
|
|
|||
| parameter_types! { | |||
| pub const BrokerId: u32 = BROKER_ID; | |||
| pub MaxXCMTransactWeight: Weight = Weight::from_parts(200_000_000, 20_000); | |||
There was a problem hiding this comment.
Set lease has three reads and a write, independent of the ref time of the actual function on that runtime that already means a ref_time of 175_000_000. Is it worth leaving a bit more of a buffer to account for fluctuations in benchmarking on top of this?
eskimor
approved these changes
Apr 18, 2024
acatangiu
reviewed
Apr 18, 2024
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
bkchr
force-pushed
the
bkchr-expose-max-transact-weight
branch
from
f72e3c0
to
c50659a
Compare
seadanda
approved these changes
Apr 19, 2024
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/kusama-v1-2-0-coretime-migration-xcm-failure-a-postmortem/7536/1 |
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be configured on the runtime level and not somewhere inside the pallet.