Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust xcm-bridge-hub-router's SendXcm::validate behavior for NotApplicable #4162

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Adjust xcm-bridge-hub-router's SendXcm::validate behavior for NotApplicable #4162

merged 4 commits into from
Apr 17, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Apr 16, 2024 •
edited
Loading

This PR adjusts xcm-bridge-hub-router to be usable in the chain of routers when a NotApplicable error occurs.

Closes: #4133

TODO

  • backport to polkadot-sdk 1.10.0 crates.io release

@bkontur bkontur mentioned this pull request Apr 16, 2024
Closed
2 tasks
@bkontur bkontur added R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. T15-bridges This PR/Issue is related to bridges. labels Apr 16, 2024
@bkontur bkontur changed the title Fix for bridge-hub-router - issue#4133 Adjust xcm-bridge-hub-router's SendXCm::validate behavior for NotApplicable Apr 17, 2024
@bkontur bkontur changed the title Adjust xcm-bridge-hub-router's SendXCm::validate behavior for NotApplicable Adjust xcm-bridge-hub-router's SendXcm::validate behavior for NotApplicable Apr 17, 2024
@bkontur bkontur marked this pull request as ready for review April 17, 2024 08:43
@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 17, 2024 08:43
svyatonik
svyatonik approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@bkontur bkontur enabled auto-merge April 17, 2024 09:00
@bkontur bkontur added this pull request to the merge queue Apr 17, 2024
Merged via the queue into master with commit 4be9f93 Apr 17, 2024
141 of 147 checks passed
@bkontur bkontur deleted the bko-fix-router-4133 branch April 17, 2024 09:32
@yrong yrong mentioned this pull request Apr 17, 2024
Closed
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serban300 serban300 serban300 approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@svyatonik svyatonik svyatonik approved these changes

Assignees

@bkontur bkontur

Labels
R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. T15-bridges This PR/Issue is related to bridges.
Projects
Bridges + XCM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bridge-hub-router should not throw xcm DestinationUnsupported error
4 participants
@bkontur @svyatonik @franciscoaguirre @serban300