Contracts: Refactor test builder #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgherveou
added
R0-silent
pgherveou
commented
Apr 16, 2024
Comment on lines
+78
to
+81
| let message: Xcm<()> = Xcm::builder_unsafe() | ||
| .withdraw_asset(assets.clone()) | ||
| .deposit_asset(assets, beneficiary) | ||
| .build(); |
There was a problem hiding this comment.
@franciscoaguirre I have refactored my contracts XCM tests to use the new builders.
I am executing an XCM locally here, so I don't really need to buy_execution, is there a better choice than builder_unsafe here?
athei
approved these changes
Apr 16, 2024
sandreim
pushed a commit
that referenced
this pull request
Apr 18, 2024
- Moved `substrate/frame/contracts/src/tests/builder.rs` into a pub test_utils module, so we can use that in the `pallet-contracts-mock-network` tests - Refactor xcm tests to use XCM builders, and simplify the use case for xcm-send
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substrate/frame/contracts/src/tests/builder.rsinto a pub test_utils module, so we can use that in thepallet-contracts-mock-networktests