Run subsystem-benchmark without network latency #4068
Conversation
AndreiEres
added
R0-silent
| let latency_ms = std::time::Duration::from_millis(self.latency_ms as u64); | ||
|
|
||
| self.spawn_handle | ||
| .spawn("peer-latency-emulator", "test-environment", async move { |
There was a problem hiding this comment.
I'm not sure I understand how this should help, we would actually get scheduling noise even if latency is zero, so this change would work against making the test more deterministic by setting latency to None.
There was a problem hiding this comment.
I have the same question. How much of an improvement are we seeing and do we have any clue why that is ?
There was a problem hiding this comment.
You are right, I used to receive weird results with sending without spawning, but now checked again and everything is ok. I suppose I just had some "noise" on my laptop because of rust-analyzer.
There was a problem hiding this comment.
I would use a VM with ref hw specs to run the tests and establish gold values for the asserts.
There was a problem hiding this comment.
Yep, I reverted that
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Implements the idea from #3899
testnetprofile because we probably don't need that debug additions.After the local tests I can't say that it brings a significant improvement in the stability of the results. However, I belive it is worth trying and looking at the results over time.