Remove deprecated TryRuntime subcommand
#4017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
commented
Apr 7, 2024
|
|
||
| crates: | ||
| - name: polkadot-parachain-bin | ||
| bump: patch |
There was a problem hiding this comment.
Making these patch because the subcommands were already a noop.
ggwpez
approved these changes
Apr 7, 2024
kianenigma
reviewed
Apr 11, 2024
| @@ -61,11 +61,6 @@ pub enum Subcommand { | |||
| #[command(subcommand)] | |||
| Benchmark(frame_benchmarking_cli::BenchmarkCmd), | |||
|
|
|||
| /// Try-runtime has migrated to a standalone CLI | |||
| /// (<https://github.com/paritytech/try-runtime-cli>). The subcommand exists as a stub and | |||
| /// deprecation notice. It will be removed entirely some time after January 2024. | |||
There was a problem hiding this comment.
damn we didn't mark this as deprecated before, so it will be a breaking chaneg in all node side code of all teams... wdyt about making it deprecated now, and removing one version later? we can still fully remove it from our codebase.
There was a problem hiding this comment.
The actual command has been a noop for a few releases, it only logged that it's deprecated with instructions to use the dedicated cli :)
kianenigma
approved these changes
Apr 11, 2024
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/paritytech-update-for-april/7646/1 |
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the removal of
try-runtime-clilogic frompolkadot-sdk.