Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite pr_3817 to reflect just RUNTIME_API_VERSIONS change #3995

Closed
wants to merge 2 commits into from
Closed

Rewrite pr_3817 to reflect just RUNTIME_API_VERSIONS change #3995

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b460ef
add minor bump
asiniscalchi Apr 5, 2024
8ec2314
fix prdoc
asiniscalchi Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions prdoc/pr_3817.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,13 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Parachain Runtime API Implementations into mod apis Refactoring
title: "RUNTIME_API_VERSIONS is now publicly accessible"

doc:
- audience: Runtime Dev
description: |
This PR introduces a refactoring to the runtime API implementations within the parachain template project. The primary changes include enhancing the visibility of `RUNTIME_API_VERSIONS` to `pub` in `impl_runtime_apis.rs`, centralizing API implementations in a new `apis.rs` file, and streamlining `lib.rs`. These changes aim to improve project structure, maintainability, and readability.
`RUNTIME_API_VERSIONS` is now publicly accessible, enhancing module-wide visibility.

Key Changes:
- `RUNTIME_API_VERSIONS` is now publicly accessible, enhancing module-wide visibility.
- Introduction of `apis.rs` centralizes runtime API implementations, promoting a cleaner and more navigable project structure.
- The main runtime library file, `lib.rs`, has been updated to reflect these structural changes, removing redundant API implementations and simplifying runtime configuration by pointing `VERSION` to the newly exposed `RUNTIME_API_VERSIONS` from `apis.rs`.

Motivations:
- **Improved Project Structure**: Centralizing API implementations offers a more organized and understandable project layout.
- **Enhanced Readability**: The refactoring efforts aim to declutter `lib.rs`, facilitating easier comprehension for new contributors.

crates:
- name: sp-api-proc-macro
- name: parachain-template-node
- name: parachain-template-runtime
bump: minor
Loading