Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beefy: error logs for validators with dummy keys #3939

Merged

Conversation

acatangiu
Copy link
Contributor

@acatangiu acatangiu commented Apr 2, 2024

This outputs:

2024-04-02 14:36:02.135 ERROR tokio-runtime-worker beefy: 🥩 for session starting at block 21990151
no BEEFY authority key found in store, you must generate valid session keys
(https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot#generating-the-session-keys)

error log entry, once every session, for nodes running with Role::Authority that have no public BEEFY key in their keystore

@acatangiu acatangiu requested review from davxy, bkchr and a team April 2, 2024 11:39
@acatangiu acatangiu self-assigned this Apr 2, 2024
@acatangiu acatangiu added the R0-silent Changes should not be mentioned in any release notes label Apr 2, 2024
@acatangiu
Copy link
Contributor Author

Locally tested:

  • authority with no BEEFY public key: prints error log
  • authority with good BEEFY public key: doesn't print anything

don't know yet how to set up local run to run authority with dummy key to check it also prints error log

substrate/client/consensus/beefy/src/worker.rs Outdated Show resolved Hide resolved
@acatangiu
Copy link
Contributor Author

don't know yet how to set up local run to run authority with dummy key to check it also prints error log

actually, dummy key is registered in runtime through Session::upgrade_keys::<OldSessionKeys, _>(transform_session_keys); (see polkadot-fellows/runtimes#65) - which doesn't populate anything in offchain keystore, so it would just be empty (no BEEFY keys) unless validator operator explicitly created some

@paritytech paritytech deleted a comment from paritytech-cicd-pr Apr 2, 2024
@paritytech paritytech deleted a comment from paritytech-cicd-pr Apr 2, 2024
@acatangiu acatangiu requested a review from a team April 2, 2024 12:17
@acatangiu acatangiu enabled auto-merge April 2, 2024 12:19
@acatangiu acatangiu added this pull request to the merge queue Apr 2, 2024
Merged via the queue into paritytech:master with commit 5eff3f9 Apr 2, 2024
132 of 135 checks passed
@acatangiu acatangiu deleted the beefy-error-logs-dummykey-validators branch April 2, 2024 12:56
Ank4n pushed a commit that referenced this pull request Apr 9, 2024
This outputs:
```
2024-04-02 14:36:02.135 ERROR tokio-runtime-worker beefy: 🥩 for session starting at block 21990151
no BEEFY authority key found in store, you must generate valid session keys
(https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot#generating-the-session-keys)
```
error log entry, once every session, for nodes running with
`Role::Authority` that have no public BEEFY key in their keystore

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
This outputs:
```
2024-04-02 14:36:02.135 ERROR tokio-runtime-worker beefy: 🥩 for session starting at block 21990151
no BEEFY authority key found in store, you must generate valid session keys
(https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot#generating-the-session-keys)
```
error log entry, once every session, for nodes running with
`Role::Authority` that have no public BEEFY key in their keystore

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants