[pallet-xcm] fix transport fees for remote reserve transfers #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Seems this was missed in emulated tests because Penpal still has free message delivery 🤦 Let me add an emulated transfer regression test as well 👍 |
|
In the meantime, can you please add a prdoc for documenting the fix in the changelog? |
acatangiu
added a commit
that referenced
this pull request
Mar 22, 2024
Add `SetFeesMode { jit_withdraw: true }` before
`InitiateReserveWithdraw` instruction to allow paying JIT fees in the
executor.
This is backport of #3792
acatangiu
reviewed
Mar 22, 2024
Absolutely! |
acatangiu
changed the title
|
I added regression tests PR (to merge with this PR): girazoki#1 @girazoki PTAL and let's merge those to this PR so this PR is complete with fix and regression tests. |
franciscoaguirre
approved these changes
Mar 22, 2024
…sfers Regression tests for paritytech#3792
|
Merged @acatangiu |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
girazoki
changed the title
|
@acatangiu I dont know how to fix the prdoc failure now :(, do I need to put the title in between quotes? |
acatangiu
approved these changes
Mar 22, 2024
Merged
via the queue into
paritytech:master
with commit Mar 22, 2024
9a04ebb
128 of 133 checks passed
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Mar 24, 2024
…ech#3792) Currently `transfer_assets` from pallet-xcm covers 4 main different transfer types: - `localReserve` - `DestinationReserve` - `Teleport` - `RemoteReserve` For the first three, the local execution and the remote message sending are separated, and fees are deducted in pallet-xcm itself: https://github.com/paritytech/polkadot-sdk/blob/3410dfb3929462da88be2da813f121d8b1cf46b3/polkadot/xcm/pallet-xcm/src/lib.rs#L1758. For the 4th case `RemoteReserve`, pallet-xcm is still relying on the xcm-executor itself to send the message (through the `initiateReserveWithdraw` instruction). In this case, if delivery fees need to be charged, it is not possible to do so because the `jit_withdraw` mode has not being set. This PR proposes to still use the `initiateReserveWithdraw` but prepending a `setFeesMode { jit_withdraw: true }` to make sure delivery fees can be paid. A test-case is also added to present the aforementioned case --------- Co-authored-by: Adrian Catangiu <adrian@parity.io>
girazoki
added a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
bkontur
pushed a commit
that referenced
this pull request
Mar 26, 2024
Add `SetFeesMode { jit_withdraw: true }` before
`InitiateReserveWithdraw` instruction to allow paying JIT fees in the
executor.
This is backport of #3792
bkontur
pushed a commit
that referenced
this pull request
Mar 26, 2024
Add `SetFeesMode { jit_withdraw: true }` before
`InitiateReserveWithdraw` instruction to allow paying JIT fees in the
executor.
This is backport of #3792
This was referenced Mar 26, 2024
acatangiu
added a commit
that referenced
this pull request
Mar 26, 2024
acatangiu
added a commit
that referenced
this pull request
Mar 26, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
transfer_assetsfrom pallet-xcm covers 4 main different transfer types:localReserveDestinationReserveTeleportRemoteReserveFor the first three, the local execution and the remote message sending are separated, and fees are deducted in pallet-xcm itself:
polkadot-sdk/polkadot/xcm/pallet-xcm/src/lib.rs
Line 1758 in 3410dfb
For the 4th case
RemoteReserve, pallet-xcm is still relying on the xcm-executor itself to send the message (through theinitiateReserveWithdrawinstruction). In this case, if delivery fees need to be charged, it is not possible to do so because thejit_withdrawmode has not being set.This PR proposes to still use the
initiateReserveWithdrawbut prepending asetFeesMode { jit_withdraw: true }to make sure delivery fees can be paid.A test-case is also added to present the aforementioned case