wasm-builder: Also set mcpu for c deps
#3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkucharczyk
approved these changes
Mar 21, 2024
dmitry-markin
approved these changes
Mar 21, 2024
koute
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Note that this could in theory break builds if someone has non-Rust dependencies in their build deps, in which case it would use this flag to compile them too, and since mvp is only valid for WASM it might break them**.
I don't know of a better way of doing this though.
** - interestingly, if I pass -mcpu=mvp to clang I get this and it compiles just fine (it completely ignores the flags, which, AFAIK, it shouldn't?):
$ clang -mcpu=mvp --target=x86_64-unknown-linux-gnu hello.c
clang-16: warning: argument unused during compilation: '-mcpu=mvp' [-Wunused-command-line-argument]
but if I change the target to something else then I get this:
$ clang -mcpu=mvp --target=aarch64-unknown-linux-gnu hello.c
clang-16: error: unsupported argument 'mvp' to option '-mcpu='
...which is a little strange that it's specifically hardcoded to ignore this only on AMD64.
lexnv
approved these changes
Mar 21, 2024
s0me0ne-unkn0wn
approved these changes
Mar 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dnjscksdn98
added a commit
to bifrost-platform/polkadot-sdk
that referenced
this pull request
Jul 22, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
dnjscksdn98
added a commit
to bifrost-platform/polkadot-sdk
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3192