Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated type 'GenesisConfig' #3378

Merged
merged 26 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
cfad225
remove deprecated type 'GenesisConfig'
RomarQ Feb 18, 2024
57b6407
doc: add prdoc
RomarQ Feb 18, 2024
fbb8814
Merge branch 'master' into rq/remove-genesis-config
RomarQ Feb 18, 2024
ea02381
Merge branch 'master' into rq/remove-genesis-config
RomarQ Feb 19, 2024
90bea09
test: update ui test result
RomarQ Feb 19, 2024
9b24930
doc: update prdoc
RomarQ Feb 19, 2024
82a3d4c
doc: fix crate field in prdoc
RomarQ Feb 19, 2024
74c4626
Revert "test: update ui test result"
RomarQ Feb 19, 2024
985b372
Merge branch 'master' into rq/remove-genesis-config
liamaharon Feb 20, 2024
be39b9c
Merge branch 'master' into rq/remove-genesis-config
RomarQ Feb 21, 2024
0f6e543
Merge branch 'master' into rq/remove-genesis-config
RomarQ Feb 25, 2024
43d8b26
fix frame-ui test artifact
RomarQ Feb 25, 2024
c4b775e
Merge branch 'master' into rq/remove-genesis-config
RomarQ Feb 26, 2024
a85059c
Merge branch 'master' into rq/remove-genesis-config
RomarQ Feb 26, 2024
eb6d1a3
Merge branch 'master' into rq/remove-genesis-config
RomarQ Feb 27, 2024
7a174ce
Merge branch 'master' into rq/remove-genesis-config
RomarQ Feb 28, 2024
a723b5f
Merge branch 'master' into rq/remove-genesis-config
RomarQ Mar 1, 2024
04c82ad
Merge branch 'master' into rq/remove-genesis-config
RomarQ Mar 3, 2024
f0d06bf
raname GenesisConfig in doc comments
RomarQ Mar 4, 2024
7ce804f
Update substrate/client/chain-spec/src/genesis_config_builder.rs
RomarQ Mar 4, 2024
ed0ff00
Update substrate/client/chain-spec/src/genesis_config_builder.rs
RomarQ Mar 4, 2024
22ce32e
Update substrate/client/chain-spec/src/genesis_config_builder.rs
RomarQ Mar 4, 2024
c804178
Merge branch 'master' into rq/remove-genesis-config
RomarQ Mar 4, 2024
56ac266
Merge branch 'master' into rq/remove-genesis-config
RomarQ Mar 5, 2024
6b546d2
format
RomarQ Mar 5, 2024
aef705e
Merge branch 'master' into rq/remove-genesis-config
RomarQ Mar 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions prdoc/pr_3378.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Remove deprecated GenesisConfig

doc:
- audience: Runtime Dev
description: |
Removes deprecated type `GenesisConfig`, it was replaced by `RuntimeGenesisConfig` on May 24 of 2023.
The type `GenesisConfig` was deprecated on May 24 of 2023 [#14210](https://github.com/paritytech/substrate/pull/14210)
RomarQ marked this conversation as resolved.
Show resolved Hide resolved

crates:
- name: frame-support-procedural
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ pub fn expand_outer_config(
#fields
}

#[cfg(any(feature = "std", test))]
#[deprecated(note = "GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.")]
pub type GenesisConfig = RuntimeGenesisConfig;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you see in FRAME, there are a few more deprecated items that we can already remove. You do them in a follow up if interested :) Assuming min 6mo has passed since being marked deprecated


#[cfg(any(feature = "std", test))]
impl #scrate::sp_runtime::BuildStorage for RuntimeGenesisConfig {
fn assimilate_storage(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ error[E0277]: the trait bound `Runtime: Config` is not satisfied
26 | System: frame_system::{Pallet, Call, Storage, Config<T>, Event<T>},
| ^^^^^^ the trait `Config` is not implemented for `Runtime`
|
note: required by a bound in `frame_system::GenesisConfig`
RomarQ marked this conversation as resolved.
Show resolved Hide resolved
note: required by a bound in `GenesisConfig`
--> $WORKSPACE/substrate/frame/system/src/lib.rs
|
| pub struct GenesisConfig<T: Config> {
Expand Down
Loading