Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset Conversion: doc guide to address incorrect exchange rate for non-withdrawable pool #3275

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Asset Conversion: doc guide to address incorrect exchange rate for non-withdrawable pool #3275

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
434e606
doc guide
muharem Feb 9, 2024
ede8012
doc
muharem Feb 9, 2024
376a2cc
Merge branch 'master' into muharem-asset-conversion-incorrect-exchang…
muharem Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions substrate/frame/asset-conversion/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,11 @@ pub mod pallet {
/// Params `amount1_min`/`amount2_min` represent that.
/// `mint_to` will be sent the liquidity tokens that represent this share of the pool.
///
/// NOTE: when encountering an incorrect exchange rate and non-withdrawable pool liquidity,
seadanda marked this conversation as resolved.
Show resolved Hide resolved
/// batch an atomic call with [`Pallet::add_liquidity`] and
/// [`Pallet::swap_exact_tokens_for_tokens`] or [`Pallet::swap_tokens_for_exact_tokens`]
/// calls to render the liquidity withdrawable and rectify the exchange rate.
///
/// Once liquidity is added, someone may successfully call
/// [`Pallet::swap_exact_tokens_for_tokens`] successfully.
#[pallet::call_index(1)]
Expand Down
Loading