Small fixes coretime related fixes #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdimitrov
added
A1-insubstantial
tdimitrov
added
the
R0-silent
eskimor
approved these changes
Feb 2, 2024
eskimor
reviewed
Feb 2, 2024
| @@ -264,7 +264,7 @@ mod tests { | |||
| let mut configs_to_check = v11::PendingConfigs::<Test>::get().unwrap(); | |||
| configs_to_check.push((0, v11.clone())); | |||
|
|
|||
| for (_, v10) in configs_to_check { | |||
| for (_, v11) in configs_to_check { | |||
There was a problem hiding this comment.
good catch! Maybe we should move the v11 above into its own scope {} with that assert.
bkchr
approved these changes
Feb 2, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains small fixes for:
HostConfig v11storage migration - v11 was compared with itself instead of withv10.ClaimQueue