Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nomination pools: Fix payout destination in permissionless unbond #3110

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Nomination pools: Fix payout destination in permissionless unbond #3110

merged 7 commits into from
Jan 30, 2024

Conversation

kianenigma
Copy link
Contributor

This fixes a bug in nomination pools that msitakenly claimed the rewards, upon pool destruction, into the caller of unbond and not the actual member.

More description and a PA coming soon. Opening this for now to expediate backport.

@kianenigma kianenigma requested review from a team January 29, 2024 15:15
@kianenigma kianenigma mentioned this pull request Jan 29, 2024
Merged
@ggwpez ggwpez requested review from gpestana and rossbulat January 29, 2024 15:43
@kianenigma kianenigma added the T2-pallets This PR/Issue is related to a particular pallet. label Jan 29, 2024
gpestana
gpestana approved these changes Jan 29, 2024
View reviewed changes
substrate/frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved
@kianenigma kianenigma mentioned this pull request Jan 29, 2024
Closed
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5062776

@kianenigma kianenigma enabled auto-merge January 30, 2024 12:29
@kianenigma kianenigma added this pull request to the merge queue Jan 30, 2024
@kianenigma kianenigma removed this pull request from the merge queue due to a manual request Jan 30, 2024
@kianenigma kianenigma added this pull request to the merge queue Jan 30, 2024
Merged via the queue into master with commit a190e0e Jan 30, 2024
116 of 121 checks passed
@kianenigma kianenigma deleted the kiz-fix-pools branch January 30, 2024 13:51
Morganamilo pushed a commit that referenced this pull request Jan 30, 2024
@kianenigma @gpestana
(backport) Nomination pools: Fix payout destination in permissionless…
88ee97e 
… unbond (#3112)

backport of #3110

---------

Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@kianenigma @gpestana
Nomination pools: Fix payout destination in permissionless unbond (pa…
b55b42e 
…ritytech#3110)

This fixes a bug in nomination pools that msitakenly claimed the
rewards, upon pool destruction, into the caller of `unbond` and not the
actual member.

More description and a PA coming soon. Opening this for now to expediate
backport.

---------

Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
@Aideepakchaudhary Aideepakchaudhary mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpestana gpestana gpestana approved these changes

@rossbulat rossbulat rossbulat approved these changes

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kianenigma @paritytech-cicd-pr @gpestana @rossbulat @liamaharon