Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approval-voting: Move verbose log from debug to tracing #3019

Merged
merged 1 commit into from
Jan 22, 2024
Merged

approval-voting: Move verbose log from debug to tracing #3019

merged 1 commit into from
Jan 22, 2024

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Jan 22, 2024

... it was like that before it was accidentally changed in a84dd0d

@alexggh
approval-voting: Move verbose log from debug to tracing
252961f 
... it was like that before it was accidentally changed in
a84dd0d

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
AndreiEres
AndreiEres approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@AndreiEres AndreiEres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why?

@sandreim sandreim added R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”. A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Jan 22, 2024
@sandreim sandreim added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit 95ff9b2 Jan 22, 2024
134 of 137 checks passed
@sandreim sandreim deleted the alexaggh/fix_logging_level branch January 22, 2024 22:20
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskimor eskimor eskimor approved these changes

@AndreiEres AndreiEres AndreiEres approved these changes

@s0me0ne-unkn0wn s0me0ne-unkn0wn s0me0ne-unkn0wn approved these changes

@sandreim sandreim sandreim approved these changes

Assignees
No one assigned
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexggh @eskimor @AndreiEres @s0me0ne-unkn0wn @sandreim