-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove sp-std #3008
remove sp-std #3008
Conversation
Nice, I could close it #2818 |
Can we deprecate it before delete it? You might be having fun doing this for polkadot-sdk but I am sure parachain teams are all busy and don't really want to repeat this big chunk of changes in our repo on next upgrade. |
Yes, let's not break our downstream users. We should do this in two steps:
Also, considering the size of this PR and the amount of places it will touch it might be easier to do this in multiple PRs instead of changing everything at once (e.g. pick one subdirectory per PR and only change things there). |
As @koute said, I suggest to remove usage of I'd follow a procedure similar to what has been done for According to the guidelines we also need to create an issue (maybe we can just use #2101 and add the |
Agreed. Once I have defeated the CI for this combined PR I will raise incremental PRs that have subsets of these changes in. I think the deprecation route of 6 months seems a good one. |
The CI pipeline was cancelled due to failure one of the required jobs. |
This PR seeks to make things a little more normal for regular rust developers coming to substrate. Some previously private types are now not as the types are now stable.
Fixes #2101