Bulk Assigner Test Implementations #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradleyOlson64
added
the
T8-polkadot
BradleyOlson64
had a problem deploying
to
master
GitHub Actions
Failure
BradleyOlson64
had a problem deploying
to
master
GitHub Actions
Failure
BradleyOlson64
had a problem deploying
to
master
GitHub Actions
Failure
eskimor
approved these changes
Nov 10, 2023
| ..CoreState::default() | ||
| let expected_descriptor_1: CoreDescriptor<BlockNumberFor<Test>> = | ||
| CoreDescriptor { queue: None, current_work: None }; | ||
| let expected_descriptor_2 = CoreDescriptor { |
There was a problem hiding this comment.
More descriptive naming would make this more readable. E.g. empty_descriptor, single_entry_descriptor.
| @@ -461,12 +534,21 @@ fn assignment_proportions_in_core_state_work() { | |||
| Some(BulkAssignment::Bulk(task_1.into())) | |||
| ); | |||
| // Pos should have incremented, as assignment had remaining < step | |||
| assert_eq!(Workload::<Test>::get(core_idx).pos, 1u16); | |||
| assert_eq!( | |||
| CoreDescriptors::<Test>::get(core_idx) | |||
There was a problem hiding this comment.
One more pop would be nice, to see that it advances to task 2. You are checking pos already, but still would be nice :-)
eskimor
pushed a commit
that referenced
this pull request
Nov 14, 2023
Addressed comments from #2262 Also added tests to cover the new cases: - Test that assignments are served correctly. E.g. two equal assignments will be served as ABABAB - Have a test that checks that core is shared fairly, even in case of `ratio` not being divisible by `step`
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 27, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…itytech#2264) * GRANDPA: optimize votes_ancestries when needed * Address review comments
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented bulk assigner tests covering all invariants thought of thus far.