-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding can request tests #1528
Adding can request tests #1528
Conversation
The CI pipeline was cancelled due to failure one of the required jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but should cases 2 and 3 perhaps be separate tests? Can testing for one in the same test, affect the outcome of the other one later on?
@mrcnski I think we're all fine on that front. I'm testing the two request-response behaviors on different peers, |
bot merge |
@BradleyOlson64 |
Closes #1478
For this issue we wanted to add tests to cover three cases:
Case 1 is already covered by the test
seconded_statement_leads_to_request
inpolkadot/node/network/statement-distribution/src/vstaging/tests/cluster.rs
Cases 2 and 3 are covered by the new test
local_node_checks_that_peer_can_request_before_responding
added in this PR