Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nft apis to kusama + polkadot asset hub runtimes #1448

Closed
wants to merge 10 commits into from
Closed

add nft apis to kusama + polkadot asset hub runtimes #1448

wants to merge 10 commits into from

Conversation

gilescope
Copy link
Contributor

@gilescope gilescope commented Sep 7, 2023 •
edited
Loading

Now that the NFT pallet is released we should also release the NFT runtime APIs.
Tasks:

  • use associated types rather than concrete types where possible.

@gilescope gilescope added the T4-runtime_API This PR/Issue is related to runtime APIs. label Sep 7, 2023
@paritytech-ci paritytech-ci requested review from a team September 7, 2023 14:07
@gilescope gilescope marked this pull request as draft September 7, 2023 14:57
@gilescope gilescope marked this pull request as ready for review September 8, 2023 13:11
@gilescope gilescope enabled auto-merge (squash) September 9, 2023 11:27
@gilescope
Copy link
Contributor Author

(This needs to land so that the constants are exposed before the corollary can be landed in the runtime repo.)

@jsidorenko
Copy link
Contributor

It would be ideal to wait for this PR to get merged first: #1914
In that case, we won't break the public API

@gilescope
Copy link
Contributor Author

Happy to put a note on the runtime PR that we should not merge it till the PR you mentioned has landed. Agreed we want to minimise breaking changes.

@jsidorenko
Copy link
Contributor

sounds good!

@gilescope
Copy link
Contributor Author

Ok those changes are all incorporated now.

joepetrowski
joepetrowski reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a Fellowship PR for Polkadot and Kusama.

cumulus/parachains/runtimes/assets/common/src/lib.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/assets/common/src/lib.rs Outdated Show resolved Hide resolved
gilescope and others added 2 commits October 27, 2023 10:32
@gilescope @joepetrowski
Update cumulus/parachains/runtimes/assets/common/src/lib.rs
ecbf74d 
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@gilescope @joepetrowski
Update cumulus/parachains/runtimes/assets/common/src/lib.rs
c84a2f0 
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
auto-merge was automatically disabled November 15, 2023 13:29

Merge queue setting changed

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
3f79e3c
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
0d2b7ec
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
8ed4871
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
b8a154a
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
0433cff
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
0cec8d0
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
db97051
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
dc50ca8
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
78a91a9
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
ba0efa9
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
368d583
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
fix another clippy warning (paritytech#1448)
c655766
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
fix another clippy warning (#1448)
ee5b692
This was referenced Jun 5, 2024
Closed
Closed
@bkchr bkchr closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepetrowski joepetrowski joepetrowski left review comments

@jsidorenko jsidorenko jsidorenko approved these changes

@georgepisaltu georgepisaltu georgepisaltu approved these changes

Assignees
No one assigned
Labels
T4-runtime_API This PR/Issue is related to runtime APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gilescope @jsidorenko @joepetrowski @georgepisaltu @bkchr