Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge CODEOWNERS Part 2 #1415

Closed
wants to merge 13 commits into from
95 changes: 95 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
# Lists some code owners.
#
# A codeowner just oversees some part of the codebase. If an owned file is changed then the
# corresponding codeowner receives a review request. An approval of the codeowner might be
# required for merging a PR (depends on repository settings).
#
# For details about syntax, see:
# https://help.github.com/en/articles/about-code-owners
# But here are some important notes:
#
# - Glob syntax is git-like, e.g. `/core` means the core directory in the root, unlike `core`
# which can be everywhere.
# - Multiple owners are supported.
# - Either handle (e.g, @github_user or @github/team) or email can be used. Keep in mind,
# that handles might work better because they are more recognizable on GitHub
# and you can use them for mentioning unlike an email.
# - The latest matching rule, if multiple, takes precedence.

# Top levels
/.cargo @paritytech/ci
/.config @paritytech/ci
/.github @paritytech/ci @paritytech/release-engineering
/.gitlab @paritytech/ci
/bridges @paritytech/bridges-core
/cumulus @paritytech/cumulus-locks-review @paritytech/core-devs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/cumulus @paritytech/cumulus-locks-review @paritytech/core-devs

/docker @paritytech/ci @paritytech/release-engineering
/docs @paritytech/docs-audit
/polkadot @paritytech/polkadot-review
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think this was previously only needed for runtime files, which are going to be migrated to https://github.com/polkadot-fellows/runtimes

#1239 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you suggesting using core-devs for /polkadot as catch-all as well ?

Copy link
Member

@ordian ordian Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably start with not too strict rules and enforce other rules via PRCR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the idea here is not to be too strict but have "full" coverage for the relevant files (ie all files but things like .gitignore, etc...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely too strict

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/polkadot @paritytech/polkadot-review

/polkadot/xcm @paritytech/xcm
/scripts/ci @paritytech/ci @paritytech/release-engineering
/substrate @paritytech/SubstrateTeamLeads
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/substrate @paritytech/SubstrateTeamLeads

/prdoc @paritytech/release-engineering

.gitlab-ci.yml @paritytech/ci
.rustfmt.toml @paritytech/core-devs
Cargo.toml @paritytech/core-devs
*.md @paritytech/docs-audit

chevdor marked this conversation as resolved.
Show resolved Hide resolved
# WASM executor, low-level client <-> WASM interface and other WASM-related code
/substrate/client/allocator/ @koute
/substrate/client/executor/ @koute
/substrate/primitives/panic-handler/ @koute
/substrate/primitives/runtime-interface/ @koute
/substrate/primitives/wasm-interface/ @koute
/substrate/utils/wasm-builder/ @koute

# Systems-related bits and bobs on the client side
/substrate/client/sysinfo/ @koute
/substrate/client/tracing/ @koute

# Documentation audit
/substrate/primitives/runtime @paritytech/docs-audit
/substrate/primitives/arithmetic @paritytech/docs-audit
# /primitives/core (to be added later)
# /primitives/io (to be added later)

chevdor marked this conversation as resolved.
Show resolved Hide resolved
# Networking-related code
/substrate/client/network @paritytech/networking

# FRAME
/substrate/frame/ @paritytech/frame-coders @paritytech/docs-audit
/substrate/frame/nfts/ @jsidorenko @paritytech/docs-audit
/substrate/frame/state-trie-migration/ @paritytech/frame-coders @cheme
/substrate/frame/uniques/ @jsidorenko @paritytech/docs-audit

# GRANDPA, BABE, consensus stuff
/substrate/client/consensus/babe/ @andresilva
acatangiu marked this conversation as resolved.
Show resolved Hide resolved
/substrate/client/consensus/beefy/ @acatangiu
/substrate/client/consensus/grandpa/ @andresilva
/substrate/client/consensus/pow/ @sorpaas
/substrate/client/consensus/slots/ @andresilva
/substrate/frame/babe/ @andresilva
/substrate/frame/grandpa/ @andresilva
/substrate/primitives/consensus/pow/ @sorpaas

# BEEFY, MMR
/substrate/frame/beefy/ @acatangiu
/substrate/frame/beefy-mmr/ @acatangiu
/substrate/frame/merkle-mountain-range/ @acatangiu
/substrate/primitives/merkle-mountain-range/ @acatangiu

# Contracts
/substrate/frame/contracts/ @athei @paritytech/docs-audit

# NPoS and election
/substrate/frame/election-provider-multi-phase/ @paritytech/staking-core @paritytech/docs-audit
/substrate/frame/election-provider-support/ @paritytech/staking-core @paritytech/docs-audit
/substrate/frame/elections-phragmen/ @paritytech/staking-core @paritytech/docs-audit
/substrate/frame/nomination-pools/ @paritytech/staking-core @paritytech/docs-audit
/substrate/frame/staking/ @paritytech/staking-core @paritytech/docs-audit
/substrate/primitives/npos-elections/ @paritytech/staking-core @paritytech/docs-audit

# Cumulus
/cumulus/xcm/xcm-emulator @nachopal
/cumulus/parachains/integration-tests @nachopal
23 changes: 0 additions & 23 deletions cumulus/CODEOWNERS

This file was deleted.

6 changes: 0 additions & 6 deletions polkadot/.github/CODEOWNERS

This file was deleted.

74 changes: 0 additions & 74 deletions substrate/docs/CODEOWNERS

This file was deleted.